search

janet-lang / pkgs

A package listing for Janet.
MIT License
59 stars 25 forks source link

Tune CONTRIBUTION #21

Closed pepe closed 3 years ago

pepe commented 3 years ago

As discussed in https://github.com/janet-lang/janet/discussions/563, this is the first draft of the new contribution rules for this repository.

Please comment below if you find anything you do not like or think could be written better.

EJIFG

bakpakin commented 3 years ago

I like the new guidelines and especially the emphasis on making it work with jpm.

pepe commented 3 years ago

One more thing that comes to mind is the optional janet- prefix in the GitHub repository to avoid name clashes for more general package names, e.g., sh, bigint, or set.

pepe commented 3 years ago

In #22, I show an example of Tier 3 (in my eyes) package.

sogaiu commented 3 years ago

This is perhaps a minor point, but some software is in the public domain, so there is strictly speaking no license IIUC.

It seems a bit weird to say "public domain" or "cc0" in a license field.

pepe commented 3 years ago

@sogaiu that is an excellent point. What about then not having :license field but point to your pd/cc in the readme and point to it in the PR? For me, sure, it is enough.

pepe commented 3 years ago

Anyway, one brilliant bird chirped some more betterment on the text in DM. I will add them today, and if no one objects anything, I will merge this at 18:00 UTC

sogaiu commented 3 years ago

@pepe Thanks for the comments about the license. Perhaps we can discuss some text along the lines you suggested in a future PR.