in argparse, a cfunction cannot be used for :map

[jmckernon]

(use spork/argparse)
(pp (argparse nil "foo" {:kind :option :map |(scan-number $)})) # returns 3
(pp (argparse nil "foo" {:kind :option :map scan-number})) # returns "3"

[pepe]

It is correct, as per https://github.com/janet-lang/spork/blob/master/spork/argparse.janet#L127. I do not see any issue to change this behavior.

[jmckernon]

In my example, is it somehow better apply |(scan-number $) than scan-number? I don't see why. I don't have to care whether a function is a cfunction or not when I use one elsewhere; why should I here?

[sogaiu]

I went looking in the original repository for argparse and in the first commit (function? ...) is used (a slightly different location).

I think the current code under discussion was added by @tionis -- and it seems reasonable to suppose that the earlier code was emulated (perhaps he remembers).

Perhaps this was just an oversight in the original formulation -- may be the intent was actually something like:

(or (function? ...) (cfunction? ...)

and the pattern was just replicated?

[jmckernon]

Thankyou for looking into it.

I can't speak for the original intention, but (or (function? ...) (cfunction? ...) is closer to the behaviour I would have expected.

[tionis]

I just didn't think to check for cfunctions when adding :map

[tionis]

I added a pull request that should fix it (just added the check as @sogaiu suggested)

[jmckernon]

Happy with that. Thanks to you all for your help.