search

janet-lang / spork

Various Janet utility modules - the official "Contrib" library.
MIT License
119 stars 35 forks source link

allow cfunctions in argparse :map #158

Closed tionis closed 10 months ago

tionis commented 11 months ago

Fixes #157

sogaiu commented 11 months ago

Thanks for this.

On a similar note, I wonder about this bit. I'm not too familiar with argparse (^^;

Any thoughts?

tionis commented 11 months ago

You mean :action? This just executes the function at parse time

sogaiu commented 11 months ago

I guess so.

The thing is, it's also just checking via only function? -- wondering whether it would make sense to change that too.

pepe commented 10 months ago

The thing is, it's also just checking via only function? -- wondering whether it would make sense to change that too.

This makes sense. Another PR will be fine I guess. Or @tionis do you think you can add it to this one, please?

tionis commented 10 months ago

I guess so.

The thing is, it's also just checking via only function? -- wondering whether it would make sense to change that too.

You're right! I just added the change