search

janet-lang / spork

Various Janet utility modules - the official "Contrib" library.
MIT License
124 stars 36 forks source link

allow cfunctions in argparse :map #158

Closed tionis closed 1 year ago

tionis commented 1 year ago

Fixes #157

sogaiu commented 1 year ago

Thanks for this.

On a similar note, I wonder about this bit. I'm not too familiar with argparse (^^;

Any thoughts?

tionis commented 1 year ago

You mean :action? This just executes the function at parse time

sogaiu commented 1 year ago

I guess so.

The thing is, it's also just checking via only function? -- wondering whether it would make sense to change that too.

pepe commented 1 year ago

The thing is, it's also just checking via only function? -- wondering whether it would make sense to change that too.

This makes sense. Another PR will be fine I guess. Or @tionis do you think you can add it to this one, please?

tionis commented 1 year ago

I guess so.

The thing is, it's also just checking via only function? -- wondering whether it would make sense to change that too.

You're right! I just added the change