Closed mraveloarinjaka closed 9 months ago
That does look like a mismatch.
Using tabseq
seems better and it's what pcall
(which also uses join
) does -- perhaps that's something that motivated the specific proposed changes :)
Just spelling things out here for other reviewers.
Hello, What are the next steps? It is not clear whether I should amend the changes or if I am missing something.
My earlier comment was just saying that the proposed changes looked on the ok side. Sorry if that was unclear.
I think this PR and some others are awaiting the main maintainer's availability -- AFAIU he is pretty busy.
There is a crash when using pmap-full because the list of fibers passed to "join" is an array and not a table. The fix aligns pmap-full implementation to pcall.