janet-lang / spork

Various Janet utility modules - the official "Contrib" library.
MIT License
122 stars 35 forks source link

contribution guidelines for adding multi-file modules/libraries? #26

Closed uvtc closed 3 years ago

uvtc commented 3 years ago

It looks to me like spork currently contains only single-file modules. However, some modules that may be a good fit for inclusion into spork may contain multiple files, their own tests, docs, etc. It is not clear how one would create a PR for inclusion of modules/libraries of this type. Would it make sense for there to be a contributions doc for this repository, specifically including guidelines for how to weave in these kinds of "larger" libraries?

uvtc commented 3 years ago

One that came to mind is tomlin.

uvtc commented 3 years ago

Or is spork better kept simple and for single-file modules?

bakpakin commented 3 years ago

Currently, I think spork is best served by smaller, janet only modules. One reason for this is adding C modules means it may be harder to install in some platforms, but I'm not making a hard line here.

pepe commented 3 years ago

Thank you very much for the answer. I will link the answer to the spork discussion.

pepe commented 3 years ago

I guess we can close this, @uvtc.

uvtc commented 3 years ago

Yup. Thanks.