search

janet-lang / spork

Various Janet utility modules - the official "Contrib" library.
MIT License
122 stars 35 forks source link

sh/make-new-file (mostly) ignores mode argument #98

Closed sogaiu closed 1 year ago

sogaiu commented 1 year ago

In https://github.com/janet-lang/spork/commit/ae9db3d5c953d54a0cca74f9352db160e749fce9, it looks like some steps were made toward making it possible for a caller of sh/make-new-file to specify a mode when it opens a file.

However, the mode argument appears to be unused by the file/open call: https://github.com/janet-lang/spork/blob/63f656e6f41b469b484903373187e96616eac837/spork/sh.janet#L95-L104

sogaiu commented 1 year ago

99 was merged so I'm closing this.