janevu / podchess

Automatically exported from code.google.com/p/podchess
GNU General Public License v3.0
1 stars 0 forks source link

Timer: should not stop when in Move-Review #18

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The current timer stops when in Move-Review mode. This is not a correct 
behavior because it 
should still "cost" the user/player time when he/she activates the Move-Review.

*** Note: In later versions when we will connect to a remote server, this timer 
feature will become 
very critical (for PodChess to keep track or sync the time correctly).

Original issue reported on code.google.com by huypha...@gmail.com on 11 Oct 2009 at 2:50

GoogleCodeExporter commented 9 years ago
Check in the 1st phase of the solution for this bug:
- Fixed the Timer update by carefully creating the timer(s) *only* in the main 
UI Thread. According to Apple 's 
Documentation, we should only "invalidate" the timer from the same thread on 
which the timer was installed. In 
PodChess, this thread is the main UI thread (instead of the AI/robot thread).

This change is risky! Moretesting needs to be done.

SVN revision: http://code.google.com/p/podchess/source/detail?r=90

Original comment by huypha...@gmail.com on 11 Oct 2009 at 8:17

GoogleCodeExporter commented 9 years ago
On networked games, at least one Move made by EACH player before the timer is 
started. However, it is more 
user-friendly for PodChess (with playing-with-AI as the only feature) to start 
the timer right after one Move is 
made (by RED) so that we know the App is not frozen.

CHANGES: http://code.google.com/p/podchess/source/detail?r=92

Original comment by huypha...@gmail.com on 12 Oct 2009 at 1:39