search

janeyho / DAT_SF_16

0 stars 0 forks source link

HW3 review #3

Open ulogan opened 9 years ago

ulogan commented 9 years ago

@janeyho

Nice work, I could understand the code well, well documented, I think I ran into a similar problem like the one in your line 28, I took Justin's help and understood the way to apply features and factors and got past it

Also you had mentioned that you could not complete Naive Bayes. (I refereed to notebook file from Justin after implementing the cross validate couple of ways and got it completed). Single function to use for both Neighbors and Naive Bayes.

@ghego @jbreucopter

ghego commented 9 years ago

good job doing the imputation of 0 values! What happened with NB? Do you need any help?

ghego commented 9 years ago

Keep rocking!