janezd / baycomp

MIT License
69 stars 15 forks source link

Use recent pystan version (3.4.0) #11

Closed dpaetzel closed 2 years ago

dpaetzel commented 2 years ago

Reasons for this change:

The PyStan version this package used before (2.19.1.1) is almost three years old now. Other projects require a more recent version (typically > 3.0.0) which leads to incompatibilities if baycomp is meant to be used in those projects. Aside from that, PyStan 3.0.0 was a complete rewrite with a much cleaner user experience (e.g. model caching by default). A summary of changes from PyStan 2.19.1.1 to 3.0.0 can be found here.

Summary of changes/implications for baycomp:

Note that I deliberately did not perform any other changes (e.g. regarding code formatting etc.) so that the changeset can be checked straightforwardly.

janezd commented 2 years ago

Great, thanks!

dpaetzel commented 2 years ago

Thank you for merging! :slightly_smiling_face: