janezd / baycomp

MIT License
69 stars 15 forks source link

Add random state to two_on_multiple #8

Closed luccaportes closed 3 years ago

luccaportes commented 3 years ago

Hi, I think it would be useful to have a random_state parameter to the two_on_multiple function, so we can provide reproducible code. I will submit a pull request with this modification, I did as few modifications as possible, the random_state parameter followed the same "path" as n_samples. That is, being treated as a kwarg until the Test object is instantiated.

I also had to update one test so it matches the call with the new parameter.