search

janfeitsma / MRA-prototype

MRA (Robocup MSL Reference Architecture) prototype
MIT License
5 stars 0 forks source link

Create github action cmake.yml [help needed] #15

Closed janfeitsma closed 1 year ago

janfeitsma commented 1 year ago

Setup first CI github action: cmake. (Because I broke something :).)

Edit: parking this, see also help request https://github.com/janfeitsma/MRA-prototype/issues/4.

janfeitsma commented 1 year ago

Weird, this branch and MR should not have been merged.

It was marked as draft, also with "help needed", and I did not request a review. The CI actions only support bazel at the moment, not cmake...

Help is still needed. (And I think it is time to start protecting the main branch?)

Edit: ah, I made a mistake when branching ci/bazel (from ci/cmake instead of main), maybe that caused the confusion, if it was implicitly merged (?).

jveijck commented 1 year ago

@janfeitsma Oops, it is indeed confusing and certainly unintended. I know that gitlab does not execute a merge if branch is marked as draft. If the MR title starts with "Draft:" it will not merge. Is it possible to add rules to Github to prevent this kind of errors.

Proposed updates: 1) It would be good to add a Cmake build step, similar to bazel build step. This could prevent that Cmake build breaks after a merge.

2) MR starting with "Draft:" in title should not be able to be merged to main (similar to Gitlab). I don't know if it is possible, but it would prevent issues. (or check if draft is ticked)

3) update MRA-build.py with cmake option would be nice. Also option to run both would be useful. With single command you can then start bazel build, cmake build and execute the tests. If all pass then it is possible to commit it (and merge if needed)

4) extend MRA-codegen to support CMakeList.txt generation. Perhaps per component an build info file should be created. This build info file is used by MRA-codegen to generate bazel and CMakeList.txt

""