janfeitsma / MRA-prototype

MRA (Robocup MSL Reference Architecture) prototype
MIT License
5 stars 0 forks source link

Robotsports getball mergefixes #6

Closed janfeitsma closed 1 year ago

janfeitsma commented 1 year ago

I tried it out.

Repaired code after last merge, I had been changing a lot in main, sorry about that, fix was trivial :).

Now it builds (bazel) and runs! So theoretically i could already try your code inside our Falcons software.

There is however one failing testcase:

 RUN      ] RobotsportsGetballFetchTest.matchKickoff
base/test_factory.hpp:36: Failure
Expected equality of these values:
  convert_proto_to_json_str(actual_output)
    Which is: "{\"actionresult\":\"RUNNING\",\"target\":{\"position\":{\"x\":0.07,\"y\":-0.02}}}"
  convert_proto_to_json_str(expected_output)
    Which is: "{\"actionresult\":\"RUNNING\",\"target\":{\"position\":{\"x\":0.07,\"y\":-0.02,\"rz\":3.19057298}}}"
[  FAILED  ] RobotsportsGetballFetchTest.matchKickoff (3 ms)

I am not comfortable fixing this one. Note that I also have been fighting coordinate systems very recently.

According MSL spec output rz should be around pi/2, see corresponding test case at Falcons side. Right? Or maybe you forgot to fill it in?