janfri / mini_exiftool

This library is a wrapper for the Exiftool command-line application (https://exiftool.org) written by Phil Harvey. It provides the full power of Exiftool to Ruby: reading and writing of EXIF-data, IPTC-data and XMP-data. Branch master is for actual development and branch compatibility-version is for compatibility with Ruby 1.8 and exiftool versions prior 7.65.
GNU Lesser General Public License v2.1
213 stars 52 forks source link

Switch from Shellwords.escape call to quoting when saving file to fix saving on windows #9

Closed jpg0 closed 11 years ago

jpg0 commented 11 years ago

Using Shellwords.escape leads to failure on windows systems which don't use the same escaping rules as unix. Instead opt to quote strings which should work on both systems (and escape quotes with a backslash).

janfri commented 11 years ago

Your solution was not yet complete: you have to escape backslashes also and escape also filenames. I've hopefully fixed the problem in version 1.7.0.