jangabrielsson / fibemu

Fibaro HC3 QuickApp emulator for vscode
https://forum.fibaro.com/topic/66394-visual-studio-code-vscode-for-quickapp-development/
MIT License
5 stars 2 forks source link

missing setup step in README.md and PDF #3

Closed fabioz23 closed 1 year ago

fabioz23 commented 1 year ago

Hi,

after repo checkout and git fetch you cannot launch fibemu since the frontend hasn't dist folder.

For creating them launch: cd .vscode/emufiles/frontend && npm run build

If you don't do that you'll receive this error on launch:

Traceback (most recent call last):
  File "~/Documents/fibemu/.vscode/emufiles/__init__.py", line 5, in <module>
    import fibapi
  File "~/Documents/fibemu/.vscode/emufiles/fibapi.py", line 94, in <module>
    app.mount("/frontend", StaticFiles(directory=".vscode/emufiles/frontend/dist"), name="frontend")
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/starlette/staticfiles.py", line 57, in __init__
    raise RuntimeError(f"Directory '{directory}' does not exist")
RuntimeError: Directory '.vscode/emufiles/frontend/dist' does not exist
jangabrielsson commented 1 year ago

Hi, sorry. What I did instead is that I added the dist folder to the repo. It's experimental at the moment but it will hopefully be the new frontend in the future - but it's not used currently

fabioz23 commented 1 year ago

@jangabrielsson you don't have to apologize, the community is just for this. we have to thank for the excellent work done with fibemu and TQAE.

I think that is enough to update the README with the command for populating dist folder before or after pip install...