jangko / nimPNG

PNG (Portable Network Graphics) decoder and encoder written in Nim
MIT License
90 stars 12 forks source link

Move tests to another repo #88

Closed exelotl closed 1 year ago

exelotl commented 1 year ago

The nimPNG repo includes a tests folder which is quite large. Also, some of the links in the tests are very inappropriate. I don't want kids using my game engine (which depends on nimPNG) to see that :see_no_evil:

image

If you install via Nimble, the test files don't get copied to the pkgs directory. However, they do remain if you are using Atlas or simply managing your own dependencies via git submodules.

Therefore I think it would be best to move the tests to another repo.

jangko commented 1 year ago

nimPNG doesn't use external links for test data. maybe they come from other sources?

exelotl commented 1 year ago

The file in question is urls.10k under nimPNG/tests/zcorpus

jangko commented 1 year ago

Thank you for looking into this. I wasn't aware there are something like this in the compression test data. They were taken from other compression project. As a compression library developer, we basically only check if the roundtrip compress-decompress works. While the content itself I never look into.

I will remove it.