search

jangler / oracles-randomizer

Randomizer for Zelda: Oracle of Seasons and Oracle of Ages
MIT License
77 stars 19 forks source link

Add static pegasus seed drop in Moosh Nuun #123

Closed ReggX closed 4 years ago

ReggX commented 4 years ago

Reason for PR:

We talked about this softlock potential of the nuun highlands cave check on discord before and the topic of using a static pegasus drop from one of the bushes came up. I tried my hand at implementing that functionality while keeping as much vanilla code as possible.

Change Description:

Inserted a obj_Pointer into group0Map27ObjectData, with disassembly macros for easier readability:

obj_DoubleValue $9ad4 $68 $48  # vanilla data that got replaced for pointer
obj_Conditional $04            # conditional for moosh nuun
obj_ItemDrop $00 $07 $58       # Drop Pegasus Seed ($07) at coordinates 5,8
obj_EndPointer

Considerations:

  1. I included the surrounding vanilla code to make it easier to grasp the changes. Probably better to remove those when merging.

  2. I don't know if misc.yaml is the right place for those changes. I put them there because I don't know where else they would really fit.

jangler commented 4 years ago

Works for me, but can you PR to patch instead of dev?

ReggX commented 4 years ago

The branch is based on jangler/dev, so changing the PR target would mean merging all current dev changes to patch.

But I can just make a branch based on patch, port the change and change source branch. Gimme a minute.