Closed simonostendorf closed 6 months ago
Hey @simonostendorf,
thank you for submitting this awesome PR! 🙂 I will merge your changes and will build a new release today.
With kind regards, Jan
Hey @simonostendorf,
after some troubles while dusting off the release process, your changes are now released as part of the 0.9.0 release. I also released the helm chart for that.
Thanks again, have fun and "viele Grüße aus Aachen 😉"
Hey @jangraefen,
thanks for reviewing and releasing this PR so fast.
(Ebenfalls viele Grüße aus Aachen :D )
This allows the
HCLOUD_TOKEN
to be read from a file. This can be useful if the token is injected using secret injection (e.g. with the vault agent injector).I tested the changes on my dev cluster. If someone is interested in using this with the vault agent injector, I used the following helm values:
This change is inspired from external-dns cloudflare provider. I requested the same change for the hcloud-cloud-controller-manager and hetzner-csi-driver to keep consistency in reading HCLOUD_TOKEN from file.