search

jangxx / netflix-1080p

Chrome extension to play Netflix in 1080p and 5.1
https://chromewebstore.google.com/detail/new-netflix-1080p/mdlbikciddolbenfkgggdegphnhmnfcg
MIT License
737 stars 57 forks source link

Adding AV1 support #46

Closed binitGajera closed 1 year ago

binitGajera commented 1 year ago
binitGajera commented 1 year ago

Had accidentally created PR for the parent repo, although if you do feel the update would be helpful do let me know and I'd be happy to create a new PR

jangxx commented 1 year ago

Sorry I'm confused, what do you mean by

Had accidentally created PR for the parent repo

Do you want me to merge this PR or not?

Looking at the actual commit I'm also not sure it makes sense to add a "Use AV1" setting, when that is already the default according to your own explanation on the settings page. I feel like it would make more sense to have a "Disable AV1" setting, so that the settings are consistent and easier to understand.

binitGajera commented 1 year ago

Do you want me to merge this PR or not?

No, I don't want it merged, I was merging a branch to my forked repo's master branch but accidentally selected your repo.

And yeah I agree there, I probably can replace "Use AV1" with "Disable AV1" for consistency, but on the other hand, I've been noticing quite low bitrates with av1 streams. So for now I think it'd be best to not add it to the extension since I myself am keeping it disabled. This is something that I just wanted to try for myself first anyway.