Create typescript types for the lib

jangxx / node-magichome

An incomplete implementation of the functionality of the "Magic Home" app. Partially a port of https://github.com/Danielhiversen/flux_led to Node.js

ISC License

124 stars 26 forks source link

Create typescript types for the lib #33

Closed skoky closed 3 years ago

skoky commented 3 years ago

It would be very useful to have typescript types file for the library. Thanks

jangxx commented 3 years ago

I don't personally use TypeScript (yet), so creating a definition file is pretty low priority for me right now.

I have documented most methods with JsHint however and was under the impression that TS can also use those comments as type definitions? Otherwise you are of course welcome to take a crack at it yourself and send a PR; I'm always happy to merge them.

jangxx commented 3 years ago

Thanks to the contribution of @z81 we now have full typescript types! They are included in version 2.7.1.