consistency for white values

jangxx / node-magichome

An incomplete implementation of the functionality of the "Magic Home" app. Partially a port of https://github.com/Danielhiversen/flux_led to Node.js

ISC License

124 stars 26 forks source link

consistency for white values #7

Closed tedstriker closed 5 years ago

tedstriker commented 5 years ago

I'd like to propose a change of percental display for warm white to its absolute value for a few reasons:

consistency with the way color values are treated
consistency with the way how to set the white brightness value (set: 0-255, get: 0-100)
provide an option to avoid rounding error problems (e.g. set white brightness to 172 (67,45%) which rounds to 67%. This would translate back to 170,85 resp. 171 rounded)

kept warm_white_percent property for compatibility/convenience purposes.

jangxx commented 5 years ago

This is a good idea, considering the warm_white_percent key is just a relic from the Python library this library is based on. Tbh, I would go even further and just remove the percent value outright. I have already argued to have the API take absolute values instead of percent https://github.com/jangxx/node-magichome/issues/5#issuecomment-421750327 and I don't see why we should include any unnecessary values in the response object.