janh / go-dsl

Library and application for reading xDSL stats
Mozilla Public License 2.0
31 stars 2 forks source link

DrayTek Vigor 167 No promt detected #10

Open baba2k opened 1 year ago

baba2k commented 1 year ago

Hi,

the Draytek Vigor 167 Fimware 5.2 promt is "Username:" instead of "Account:" so no promt detected error is thrown.

Thanks!

baba

janh commented 1 year ago

Does the connection work and provide usable data, if you change "Account:" to "Username:" in draytek/telnet.go?

baba2k commented 1 year ago

Just tested the binary, but this would solve the issue on my opinion. The telnet commands are the same as before

janh commented 1 year ago

Changing the expected prompt would probably make the initial connection work, but it may still fail later when loading data.

The output of the adsl command on other DrayTek devices contains some Lantiq-specific quirks, which the client compensates for. So even if the same commands are all available on this device, I'm not confident that the client would fully work and provide correct data without any changes.

If you test it and it actually works, I'm of course happy to add support for this different prompt. Please send me a copy of the raw.txt file then, so I have something to test against myself and can implement any fixes if necessary.

Instructions for building from source are available in the documentation. If you need any further help, please ask!