janh / go-dsl

Library and application for reading xDSL stats
Mozilla Public License 2.0
31 stars 2 forks source link

dsl-gui ssh login fails when a passphase is used to secure access to the private keys #4

Closed moeller0 closed 2 years ago

moeller0 commented 2 years ago

So I "secured" access to my private keys behind a passphrase and the CLI application sort of works:

computer:go-dsl user$ ./dsl

Connecting… passphrase required
Fingerprint: SHA256:rcl9qcANmVORxAH5pPkMDL8TCtu+Z9jDNVmfTKLdjqo
Passphrase: 
Authenticating… done
Loading data… done

           State:    Showtime
            Mode:    VDSL2 Profile 17a
          Uptime:    32 days, 16 hours, 11 minutes

          Remote:    Broadcom 12.4.127 (194.127)
           Modem:    Infineon 5.9.1.4.0.7

     Actual rate:      116797 kbit/s      36998 kbit/s 
 Attainable rate:      140083 kbit/s      40043 kbit/s 
         MINEFTR:       81349 kbit/s    1730261 kbit/s 

         Bitswap:          on                on        
   Rate adaption:         off               off        

    Interleaving:        0.14 ms              0 ms     
             INP:        40.0 symbols      44.0 symbols
  Retransmission:          on                on        

       Vectoring:        full              full        

     Attenuation:         9.8 dB            8.3 dB     
      SNR margin:        12.5 dB            8.5 dB     
  Transmit power:        14.5 dBm          -3.5 dBm    

    RTX TX Count:      335827             37924        
     RTX C Count:       32108            223166        
    RTX UC Count:         762           1487052        

       FEC Count:           0              4298        
       CRC Count:          23               321        

        ES Count:           5               128        
       SES Count:           1                76        

but when I try the same with dsl-gui I get a prompt "The device requests a password" which neither accepts: 1) an empty password 2) the modems password 3) my ssh passphrase:

computer:go-dsl user$ ./dsl-gui 
setting password failed: no password required
setting password failed: no password required
setting password failed: no password required

Which is a pity as the 4 "spectral" plots are really nice and informative.

janh commented 2 years ago

Looks like the web/GUI client switched to the wrong state when a passphrase is required.

This should be fixed now. Can you check if it works?

moeller0 commented 2 years ago

Thanks, now the dialog request makes sense and accepts my passphrase, after which the GUI works as intended.

Thanks again!