janheinrichmerker / android-issue-reporter

A powerful and simple library to open issues on GitHub directly from your app.
MIT License
118 stars 27 forks source link

GitHub API library replacement #154

Closed cyb3rko closed 10 months ago

cyb3rko commented 10 months ago

Closes #153

Changes

Switched to hub4j/github-api, really wasn't a big change.

BUT at the moment without R8 support. Trying to build a release app current kills the library.
I'm trying to fix that, help appreciated.

Do you want to already merge or wait for the R8 support?


Missing class com.infradna.tool.bridge_method_injector.BridgeMethodsAdded (referenced from: org.kohsuke.github.GHIssue and 4 other contexts)
Missing class edu.umd.cs.findbugs.annotations.NonNull (referenced from: org.kohsuke.github.GitHubRequest$Builder org.kohsuke.github.GitHubRequest$Builder.injectMappingValue(java.lang.Object) and 1 other context)
Missing class edu.umd.cs.findbugs.annotations.SuppressFBWarnings (referenced from: int org.kohsuke.github.extras.ImpatientHttpConnector.CONNECT_TIMEOUT and 14 other contexts)
Missing class javax.annotation.CheckForNull (referenced from: org.kohsuke.github.GHMyself org.kohsuke.github.GitHub.myself and 23 other contexts)
Missing class javax.annotation.Nonnull (referenced from: java.util.Date org.kohsuke.github.GHRateLimit$Record.resetDate and 96 other contexts)
Missing class javax.annotation.Nullable (referenced from: java.lang.String org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory.getSystemProperty(java.lang.String, java.lang.String) and 2 other contexts)
Missing class javax.annotation.WillClose (referenced from: org.kohsuke.github.GitHubRequest$Builder org.kohsuke.github.GitHubRequest$Builder.with(java.io.InputStream))
Missing class okhttp3.Cache (referenced from: okhttp3.Call org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$OkHttpURLConnection.buildCall() and 2 other contexts)
Missing class okhttp3.CacheControl$Builder (referenced from: void org.kohsuke.github.extras.okhttp3.OkHttpConnector.<init>(okhttp3.OkHttpClient, int) and 1 other context)
Missing class okhttp3.CacheControl (referenced from: void org.kohsuke.github.extras.okhttp3.OkHttpConnector.<init>(okhttp3.OkHttpClient, int) and 1 other context)
Missing class okhttp3.Call (referenced from: okhttp3.Call org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$OkHttpURLConnection.call and 8 other contexts)
Missing class okhttp3.Callback (referenced from: void org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$OkHttpURLConnection.connect() and 1 other context)
Missing class okhttp3.CipherSuite (referenced from: java.lang.String org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$DelegatingHttpsURLConnection.getCipherSuite())
Missing class okhttp3.ConnectionSpec (referenced from: java.util.List org.kohsuke.github.extras.okhttp3.OkHttpConnector.TlsConnectionSpecs() and 1 other context)
Missing class okhttp3.Dispatcher (referenced from: okhttp3.Call org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$OkHttpURLConnection.buildCall())
Missing class okhttp3.Handshake (referenced from: okhttp3.Handshake org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$OkHttpURLConnection.handshake and 8 other contexts)
Missing class okhttp3.Headers$Builder (referenced from: okhttp3.Headers$Builder org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$OkHttpURLConnection.requestHeaders and 8 other contexts)
Missing class okhttp3.Headers (referenced from: okhttp3.Headers org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$OkHttpURLConnection.responseHeaders and 11 other contexts)
Missing class okhttp3.HttpUrl (referenced from: okhttp3.Call org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$OkHttpURLConnection.buildCall() and 2 other contexts)
Missing class okhttp3.Interceptor (referenced from: okhttp3.Interceptor org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$UnexpectedException.INTERCEPTOR and 2 other contexts)
Missing class okhttp3.OkHttpClient$Builder (referenced from: okhttp3.Call org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$OkHttpURLConnection.buildCall() and 9 other contexts)
Missing class okhttp3.OkHttpClient (referenced from: okhttp3.OkHttpClient org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$OkHttpURLConnection.client and 28 other contexts)
Missing class okhttp3.Protocol (referenced from: okhttp3.Headers org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$OkHttpURLConnection.getHeaders() and 1 other context)
Missing class okhttp3.Request$Builder (referenced from: okhttp3.Call org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$OkHttpURLConnection.buildCall() and 1 other context)
Missing class okhttp3.Request (referenced from: okhttp3.Call org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$OkHttpURLConnection.buildCall() and 5 other contexts)
Missing class okhttp3.RequestBody (referenced from: okhttp3.Call org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$OkHttpURLConnection.buildCall() and 5 other contexts)
Missing class okhttp3.Response (referenced from: okhttp3.Response org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$OkHttpURLConnection.networkResponse and 18 other contexts)
Missing class okhttp3.ResponseBody (referenced from: okhttp3.ResponseBody org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$ResponseBodyInputStream.responseBody and 6 other contexts)
Missing class okio.Buffer (referenced from: okio.Buffer org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$BufferedRequestBody.buffer and 2 other contexts)
Missing class okio.BufferedSink (referenced from: okio.BufferedSink org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$OutputStreamRequestBody$1.val$sink and 6 other contexts)
Missing class okio.Okio (referenced from: void org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$StreamedRequestBody.<init>(long))
Missing class okio.Pipe (referenced from: okio.Pipe org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$StreamedRequestBody.pipe and 1 other context)
Missing class okio.Sink (referenced from: void org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$StreamedRequestBody.<init>(long))
Missing class okio.Timeout (referenced from: okio.Timeout org.kohsuke.github.extras.okhttp3.ObsoleteUrlFactory$OutputStreamRequestBody.timeout and 2 other contexts)
janheinrichmerker commented 10 months ago

I would say, merging this even without R8 support is sensible :+1: That can then be worked on separately.