search

janheinrichmerker / material-intro

A simple material design app intro with cool animations and a fluent API.
https://jitpack.io/#com.heinrichreimer/material-intro
MIT License
1.74k stars 305 forks source link

fix: crash while inflating ImageButton in mi_activity_intro.xml #284

Closed firefinchdev closed 4 years ago

janheinrichmerker commented 4 years ago

Can you confirm, that replacing the color reference with the hex value fixes the issue?

firefinchdev commented 4 years ago

As of now, I cant confirm the same. But searching this issue on net, I think this is the only solution. https://stackoverflow.com/a/35449255/8183406 I will use the "change" in my own app update, and can only tell you if the issue reoccurs or not after few days of usage on production.

janheinrichmerker commented 4 years ago

So you have not been able to reproduce #283?

firefinchdev commented 4 years ago

Not released my update yet, Will take some time, and need another few days to test if issue reoccurs.

firefinchdev commented 4 years ago

Please note that I was unable to reproduce the issue on my own devices, but firebase crashlytics showed many devices where the issue occurs.

janheinrichmerker commented 4 years ago

I would like to see a reproduction of #283 first, before merging this PR.

firefinchdev commented 4 years ago

Okay, will report back after some days of next release.

firefinchdev commented 4 years ago

So I deployed these changes on production, and in 7 days, there was no reoccurrence of the issue. Earlier, I had 10-15 crashes per day, but not even one on the latest release.

firefinchdev commented 4 years ago

@heinrichreimer Is it possible now to merge the PR?

firefinchdev commented 4 years ago

Also, please take a look at https://github.com/heinrichreimer/material-intro/issues/285, that issue is at the top (in terms of number of crashes) in my crashlytics console. I tried resolving this issue, but was unable to resolve it.