janhohenheim / Hippocrates

No longer maintained, actually usable implementation of NEAT
GNU Affero General Public License v3.0
63 stars 12 forks source link

Parsing with `stoul` is not portable #59

Closed janhohenheim closed 7 years ago

janhohenheim commented 7 years ago

std::size_t is not guaranteed to be an unsigned long. Code like this will fail on some architectures.

Possible fix

janhohenheim commented 7 years ago

This breaks sane windows builds and is unsafe. Possible solutions:

image

jeremystucki commented 7 years ago

Closed with #64