search

janhohenheim / pixelate_mesh

Apply a pixelation effect to any Bevy mesh or scene without post-processing.
Apache License 2.0
77 stars 5 forks source link

WIP: Add support for removing pixelation effect #6

Open naasblod opened 1 year ago

naasblod commented 1 year ago

I've fixed some bugs in the code where the cameras and canvas entity was compared with the pixelated entity instead of the target of Canvas and Camera.

I haven't really figured out what is left do do. Maybe We need to store the Original Handle<Mesh> And reinsert it in despawn_dependent_types.

I could use some help on this one @janhohenheim

janhohenheim commented 1 year ago

Thanks, I'll check in later this week :)

naasblod commented 1 year ago

Happy to help!

naasblod commented 1 year ago

When adding the Pixelate component back to the entity after removing it once, this warning prints. Should be apparent when running the example examples/toggle.rs

And each time you toggle after that it prints out 2 more of these lines. 

2023-03-27T13:48:50.639833Z  WARN bevy_hierarchy::valid_parent_check_plugin: warning[B0004]: An entity with the ComputedVisibility component has a parent without ComputedVisibility.
This will cause inconsistent behaviors! See https://bevyengine.org/learn/errors/#b0004
2023-03-27T13:48:50.639833Z  WARN bevy_hierarchy::valid_parent_check_plugin: warning[B0004]: An entity with the GlobalTransform component has a parent without GlobalTransform.
This will cause inconsistent behaviors! See https://bevyengine.org/learn/errors/#b0004
janhohenheim commented 10 months ago

Sorry for not checking this for checks date nearly a year! Oops! What's the state here? Is it working other than these warnings? Is there anything I can help with?