search

janhommes / o.js

o.js - client side oData lib.
https://janhommes.github.io/o.js/example/
MIT License
238 stars 57 forks source link

Minor fixes #43

Closed IceOnFire closed 7 years ago

IceOnFire commented 7 years ago

This pull request includes two small changes:

  1. GET requests now remove the trailing slash from the URL (e.g. instead of /Categories/ now it's /Categories). This one prevents me an error from a buggy server I have to call, but I suppose it doesn't harm anybody;
  2. Fixed a typo in the uglify script of package.json, now the output file is correctly updated.

Feel free to refuse this PR and take only what you need from it.

janhommes commented 7 years ago

Hi,

thanks for sharing. I made some fixes as well and creted a new minor release: https://github.com/janhommes/o.js/releases/tag/v0.3.1

Can you please update the npm packages? I have no access :(

Regards Jan

2017-06-05 16:55 GMT+02:00 Matteo Antony Mistretta <notifications@github.com

:

This pull request includes two small changes:

  1. GET requests now remove the trailing slash from the URL (e.g. instead of /Categories/ now it's /Categories). This one prevents me an error from a buggy server I have to call, but I suppose it doesn't harm anybody;
  2. Fixed a typo in the uglify script of package.json, now the output file is correctly updated.

Feel free to refuse this PR and take only what you need from it.

You can view, comment on, or merge this pull request online at:

https://github.com/janhommes/o.js/pull/43 Commit Summary

  • Merge pull request #3 from janhommes/master
  • Remove potentially dangerous trailing slash
  • Fix uglification not being saved to file

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/janhommes/o.js/pull/43, or mute the thread https://github.com/notifications/unsubscribe-auth/ADPb4Jnkz5JIC2Bg6f-7Kw9pOg_Nkvs1ks5sBBbXgaJpZM4NwKBe .

IceOnFire commented 7 years ago

Published! It's quite a shame that you, the author, do not have access to your own repo... I added you in the package contributors' list on npmjs.com, hoping it's sufficient.

janhommes commented 7 years ago

It is ;)

I have now access, thanks. I directly bumped to version 0.3.2 because the documentation was wrong.