feat: nightly updater - Githubissues

janhq / cortex.cpp

Run and customize Local LLMs.

https://cortex.so

Apache License 2.0

1.91k stars 105 forks source link

feat: nightly updater #1175

Closed vansangpfiev closed 1 week ago

vansangpfiev commented 1 week ago

Describe Your Changes

Support nightly updater. The binary is built with flag -DCORTEX_VARIANT="nightly" Syntax

cortex update -v <cortex_version>

default is the latest nightly

Update logic:

Download nightly binary, it is in tar format
Extract binary file
Stop the server if it is running
Rename the current binary cortex -> /temp/cortex_temp
Copy new binary to be the current binary
Clean resources: remove all downloaded data
Restore binary if encounter any issue

Fixes Issues

Closes https://github.com/janhq/cortex.cpp/issues/1170

dan-homebrew commented 1 week ago

@vansangpfiev Thanks for the Updater PR:

We need more test coverage for logic covering Nightly, Beta update download origin
I think this is the most likely failure point a year from now

vansangpfiev commented 1 week ago

@vansangpfiev Thanks for the Updater PR:

We need more test coverage for logic covering Nightly, Beta update download origin

I think this is the most likely failure point a year from now

As I mentioned above, the logic for variants should be added in CIs, not unit tests

dan-homebrew commented 1 week ago

@vansangpfiev Thanks for the Updater PR:

We need more test coverage for logic covering Nightly, Beta update download origin

I think this is the most likely failure point a year from now

As I mentioned above, the logic for variants should be added in CIs, not unit tests

I see - as long as it's covered, I agree. Lgtm