feat: `cortex start` - Githubissues

janhq / cortex.cpp

Run and customize Local LLMs.

https://cortex.so

Apache License 2.0

1.92k stars 105 forks source link

feat: `cortex start` #1232

Closed dan-homebrew closed 1 day ago

dan-homebrew commented 2 days ago

Goal

We should have a clear start command, which takes port number
This should differentiate from cortex, which should be more similar to -h and also show where data is persisted

Clarifications needed

Is cortex start a pre-requisite to cortex run?
cortex run should automatically start a server if it is not already running

Tasklist

[x] #1234

vansangpfiev commented 2 days ago

Is cortex start a pre-requisite to cortex run?

Yes, it is

cortex run should automatically start a server if it is not already running

We don't start server automatically yet, will add it soon

@dan-homebrew I think cortex start change is reasonable. Let me take a stab at it. However

This should differentiate from cortex, which should be more similar to -h and also show where data is persisted

this change may take time, so will work on cortex start first

dan-homebrew commented 2 days ago

Is cortex start a pre-requisite to cortex run?
Yes, it is
cortex run should automatically start a server if it is not already running
We don't start server automatically yet, will add it soon

@dan-homebrew I think cortex start change is reasonable. Let me take a stab at it. However
This should differentiate from cortex, which should be more similar to -h and also show where data is persisted
this change may take time, so will work on cortex start first

Got it, thank you @vansangpfiev

vansangpfiev commented 1 day ago

Resolved by https://github.com/janhq/cortex.cpp/issues/1234