janhq / cortex.cpp

Local AI API Platform

https://cortex.so

Apache License 2.0

2.16k stars 130 forks source link

feat: build macos universal for binary and installer #1396

Closed hiento09 closed 1 month ago

hiento09 commented 2 months ago

Description:

We need to enhance our build process to support macOS universal binaries and installers. This will ensure compatibility across both Intel (x86_64) and Apple Silicon (arm64) architectures.

Requirements:

Build the macOS universal binary (combining x86_64 and arm64 architectures) for the application.
Modify the installer to include the universal binary, ensuring it can run on both Intel and Apple Silicon machines.
Update the CI pipeline to automatically build the macOS universal binary and installer as part of the release process.

Acceptance Criteria:

The application should run natively on both Intel and Apple Silicon Macs.
The installer should properly detect the architecture and install the universal binary.
Verify that the build process is integrated into the CI pipeline and functions as expected.

Additional Notes:

Test on both Intel and Apple Silicon Macs to ensure compatibility.

hiento09 commented 2 months ago

We need to modify the macOS updater source code and test it as well cc @vansangpfiev @dan-homebrew @gabrielle-ong

hiento09 commented 2 months ago

Include @vansangpfiev here for the macOS updater source code change.

dan-homebrew commented 2 months ago

@hiento09 FYI, for 154, I ran the Universal installer. However, when running a model, encountered the following error:

hiento09 commented 2 months ago

@hiento09 FYI, for 154, I ran the Universal installer. However, when running a model, encountered the following error:

@dan-homebrew can I check how you installed version 154 nightly? I just tried the following scenarios for Mac silicon and Mac intel and they all succeeded:

Fresh install using the local installer universal
Fresh install using the network installer universal
Update from an older version before the Mac universal version existed

hiento09 commented 2 months ago

I just tried a scenario as follows and encountered a similar issue to what you mentioned:

My machine is a Mac Silicon
I downloaded version 152, but the mac amd64 version – it still installed because my machine has Rosetta, but at this point, the llamacpp engine installed is the amd64 variant, which causes it to not run on Mac Silicon.
I ran cortex update to download version 154 universal and tried running cortex chat tinyllama:1b-gguf.

gabrielle-ong commented 1 month ago

@hiento09 I'm closing this issue as the mac Universal installer is complete. Thank you! 🎉 Tracking this bug in a separate issue: #1422