janhq / cortex.cpp

Local AI API Platform
https://cortex.so
Apache License 2.0
2.15k stars 128 forks source link

bug: App shell conflicts between `cortex-nightly` and `cortex-stable` #1502

Open gabrielle-ong opened 1 month ago

gabrielle-ong commented 1 month ago

Cortex version

v172

Describe the Bug

App shell conflicts between cortex-nightly and cortex-stable:

when I load a model on one version, the model is loaded on both cortex and cortex-nightly when I unload the model on one version, the model is unloaded on both cortex and cortex-nightly

Not sure if this is a cortex ps issue or installation/data folder conflict with cortex and cortex-nightly

Steps to Reproduce

No response

Screenshots / Logs

image

What is your OS?

What engine are you running?

vansangpfiev commented 1 month ago

Our CLI and Server communicate by TCP IP socket for now and the Server does not know about cortex variant, so it is expected. This will be solved after we support Unix domain socket cc: @namchuai @nguyenhoangthuan99

gabrielle-ong commented 1 month ago

@vansangpfiev do we have plans to move to UDS, and should this be done earlier rather than later?

cc @dan-homebrew @0xSage

gabrielle-ong commented 1 month ago

Decision:

0xSage commented 1 month ago

Dumb/nonurgent question: If we switch to UDS, what about devs directly embedding Cortex in their apps and only using the API? Will we still support TCP/IP (the most common protocol)?

vansangpfiev commented 1 month ago

IMO, we will support both UDS and TCP/IP. Clients (CLI, Jan, ...) can switch to which protocol they want.

vansangpfiev commented 1 month ago

@gabrielle-ong A temporary solution for TCP/IP is to use different ports by configuring apiServerPort in .cortexrc*.

gabrielle-ong commented 1 month ago

Thanks @vansangpfiev, Ill use that workaround iceboxing this bug and creating a planning ticket #1517