bug: User rm -rfs the /model file, app is stuck in broken state

janhq / jan

Jan is an open source alternative to ChatGPT that runs 100% offline on your computer. Multiple engine support (llama.cpp, TensorRT-LLM)

https://jan.ai/

GNU Affero General Public License v3.0

22.14k stars 1.27k forks source link

bug: User rm -rfs the /model file, app is stuck in broken state #1072

Closed hahuyhoang411 closed 8 months ago

hahuyhoang411 commented 9 months ago

Describe the bug User deleted the model file in thejan/models folder (not using delete button in the app) but still can choose in Jan app.

Desktop

OS: Windows
Version 0.4.2

To Reproduce Steps to reproduce the behavior:

Go to jan/models/model_folder
Delete a downloaded model
Back to Jan app
Chat -> See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots

hahuyhoang411 commented 9 months ago

Close for now

tikikun commented 9 months ago

still a valid UX issue, please keep open

louis-jan commented 9 months ago

App reads from model.json, "state": "ready" means the model is ready. There would be an enhancement #1039 that could also address this by not putting state in model.json

0xSage commented 9 months ago

Good issue. Can be solved with #1052

louis-jan commented 9 months ago

I want to sneak in one more case of deleting a model. The threads created with the deleted model should display a proper error handling message. Otherwise sending new messages to this thread will block the other threads.

Created threads with "Choose a model to start" but actually can't update.