janhq / jan

Jan is an open source alternative to ChatGPT that runs 100% offline on your computer. Multiple engine support (llama.cpp, TensorRT-LLM)
https://jan.ai/
GNU Affero General Public License v3.0
20.75k stars 1.19k forks source link

feat: Better support for Japanese/ Chinese keyboard #2585

Closed hiro-v closed 2 months ago

hiro-v commented 3 months ago

Problem

Success Criteria

Additional context

zhhanging commented 3 months ago

In the inputEvent and keyboardEvent, there is an isComposing property, which can be used to determine whether the user is in input method's composing stage when triggering the input / keyboard event. https://developer.mozilla.org/en-US/docs/Web/API/InputEvent/isComposing. I think this will be an easy fix using this property. I could make a pr, but this issue is already assigned to imtuyethan. She will probably fix this soon.

Van-QA commented 3 months ago

Hi @zhhanging, please help us with the PR if possible 👍 (and link the PR to this ticket) We value the help from contributors a lot. Any ticket that you want, you can pick it up, you only need to change the assignee, and put a comment. 🙏

Van-QA commented 2 months ago

Many thank to the help of @zhhanging, the issue is now resolved as of Jan v0.4.10-368 ✅