janhq / models

Models support in Jan and Cortex
MIT License
5 stars 2 forks source link

Epic: Auto add tokenizer.model #34

Closed hahuyhoang411 closed 1 month ago

hahuyhoang411 commented 1 month ago

Problem

Sometimes the model HF repo doesn't have tokenizer.model itself which cause the bug missing tokenizer.

Recommendation

@nguyenhoangthuan99 : Add 1 more step in CI converter

https://github.com/ggerganov/llama.cpp/issues/2443

Tasks

hahuyhoang411 commented 1 month ago

I think the problem is related to our current llama.cpp version

https://github.com/ggerganov/llama.cpp/issues/6419

hahuyhoang411 commented 1 month ago

I convert the model using our internal cluster with latest llama.cpp version and it works fine

Image

Can you help me to bump the version cc @nguyenhoangthuan99

hahuyhoang411 commented 1 month ago

Problem solved with version bump

Srujan-D commented 2 weeks ago

Hi @hahuyhoang411

I am trying to add Florence model support to llama.cpp, and am facing the tokenizer.model issue. Can you please help out with what steps I need to follow to get tokenizer.model from tokenizer.json?

Thanks!