janhubicka / Color-Screen

Set of tools to work with scans of early color photographs taken using additive color screen processes
https://github.com/janhubicka/Color-Screen/wiki
GNU General Public License v3.0
4 stars 0 forks source link

finetune solver works much slower on Windows than Linux #7

Closed janhubicka closed 1 month ago

janhubicka commented 1 month ago

This may be related to the stack usage or perhaps different behaviour of OpenMP on Windows

janhubicka commented 1 month ago

Disabling openMP helps, but I am not sure why.

janhubicka commented 1 month ago

Curiously, clang's openMP is fast, but yields wrong result (only first part of image is correctly finetuned). Seems there is some sort of race.

janhubicka commented 1 month ago

set OMP_NESTED=true solves the problem both with speed of gcc implementation and wrong output with clang. There are really nested OMP regions since finetune solver calls precompute from OMP controlled region.

janhubicka commented 1 month ago

now works for me (and no one else uses this anyway :)