jani15 / firecookie

Automatically exported from code.google.com/p/firecookie
Other
0 stars 0 forks source link

Cookie name cannot start with . (dot) #101

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a new cookie, with name starting with a dot "."
2. The cookie will not be created, no errors returned
or
1. Try to edit an existing cookie, and put a dot in front of it's name
2. The name will not change, no errors returnes

What is the expected output? What do you see instead?
Create/Edit the cookie, or return an error.

What version of the product are you using? On what operating system?
Firebug 7.1, Firecookie 1.2.1, Ubuntu 10.04 Lucid

Please provide any additional information below.

Original issue reported on code.google.com by marisr...@gmail.com on 28 May 2011 at 7:43

GoogleCodeExporter commented 9 years ago
This should be merged with Issue 96 (didn't see it before adding this bug, 
sorry).

Original comment by marisr...@gmail.com on 28 May 2011 at 7:46

GoogleCodeExporter commented 9 years ago
Sorry i'm to tired tonight, the problem is with the domain name (Host), not the 
cookie name.

Original comment by marisr...@gmail.com on 28 May 2011 at 8:00

GoogleCodeExporter commented 9 years ago
Not a problem.

So, what exactly should I do to reproduce the problem on my machine?
Honza

Original comment by odva...@gmail.com on 29 May 2011 at 6:12

GoogleCodeExporter commented 9 years ago
Example: The problem is with subdomains (the dot acts like a wildcard), you can 
try it on youtube, they have a cookie named "watch_queue_new" that is used for 
play queued videos. Go to youtube.com, open firebug->firecookie and add a new 
cookie with:
Name: "watch_queue_new"
Host: ".youtube.com"
Path: "/"
Expires: check Session
Value: "PsmPF9pO56I,jeIv7b5lv74"
Click ok, normaly you should see this cookie in firecookie, but it's not there, 
if you add another cookie, and replace the host with either "www.youtube.com" 
or "youtube.com", both of them are saved. Now try to edit the cookie with 
host=youtube.com, and add a dot in front of "youtube.com" => ".youtube.com", 
click ok, the host of the cookie does not change (same thing happens if you 
delete "www" from the cookie with Host="www.youtube.com"

 ( If the cookie is saved corectly, after a refresh of the page you should see a playlist loaded with 2 videos from google development channel, if the host is not ".youtube.com" you should see a playlist wiht one invalid song in it )

Hope you can replicate this, I tried it on 2 PC's, both having the same problem 
(a laptop with Ubuntu 10.04 and a desktop with Ubuntu 11.04, both having 
Firefox 4.01, Firebug 7.1, Firecookie 1.2.1 )

Thank you for this great addon. :)

Original comment by marisr...@gmail.com on 29 May 2011 at 11:09

GoogleCodeExporter commented 9 years ago
Could you please try Firecookie 1.3b1
http://www.janodvarko.cz/firecookie/archive/firecookie-1.3b1.xpi

and let me know if it works for you?

Thanks!
Honza

Original comment by odva...@gmail.com on 30 May 2011 at 6:00

GoogleCodeExporter commented 9 years ago
It's working (add and edit), but there are 2 new problems with this version:

1. When adding the value of the cookie it is always saved encoded, the comma is 
saved as %2C, in firecookie windows the value looks god, but I gues it is 
decoded before showing it, but with native Firefox viewer the value is encoded 
( and from scripts in page ).

2. When editing the cookie, and change the the domain from "www.youtube.com" to 
".youtube.com", it created a new cookie (a god one), but doesn't delete the old 
one, so I end up with 2 cookies with the same name, but different domain.

Thank you.

Original comment by marisr...@gmail.com on 30 May 2011 at 8:07

GoogleCodeExporter commented 9 years ago
Another helpful thing, when I edit the value of the cookie (added with 
Firecookie) using "Cookie Manager" addon, the value is saved corectly (not 
encoded), and in Firecookie, the "Raw" tab from the cookie disapeared, and just 
the "Value" tab is present.

Original comment by marisr...@gmail.com on 30 May 2011 at 8:14

GoogleCodeExporter commented 9 years ago
> 1. When adding the value of the cookie it is always saved encoded
See issue 54.

> 2. When editing the cookie, and change the the domain from "www.youtube.com" 
to 
> ".youtube.com", it created a new cookie (a god one), but doesn't delete the 
old one, 
> so I end up with 2 cookies with the same name, but different domain.
I guess that's what is described in issue 40, though I'm not speaking 
Portuguese, so I'm not sure.

> Another helpful thing, when I edit the value of the cookie (added with 
Firecookie) 
> using "Cookie Manager" addon, the value is saved corectly (not encoded), and 
in 
> Firecookie, the "Raw" tab from the cookie disapeared, and just the "Value" 
tab is 
> present.
I guess that's covered by issue 54.

Since the original issue seems to be fixed, I close this issue now.

Please note that Firecookie was just integrated into Firebug 1.10a11:

http://getfirebug.com/releases/firebug/1.10/firebug-1.10.0a11.xpi

So any further testing should be based on that version.

Sebastian

Original comment by sebastia...@gmail.com on 12 Jun 2012 at 8:44