janicicpredrag / gclc

GCLC is a mathematical software tool for producing high-quality mathematical illustrations, for teaching mathematics, and for automated proving of geometry theorems.
http://www.matf.bg.ac.rs/~janicic/gclc/
Other
53 stars 7 forks source link

simplify 'CFace' vertex management #37

Closed Smattr closed 6 months ago

Smattr commented 6 months ago

In surveying the C-style casts in the code base, the next candidate that looks like it can be removed is the mallocing code in CJavaView::ReadF. This goes on to operate on a CListOfFaces which contains CFaces which in turn contain vertexs. So it made sense to start reducing complexity from the “bottom” here and work our way up to making CFace::name a std::string. Rather than try to land all of this at once, this PR just tackles the initial changes simplifying vertex and its usages.