janiko71 / aws-inventory

Python script for AWS resources inventory (cheaper than AWS Config)
GNU General Public License v3.0
164 stars 64 forks source link

Add support for RDS Aurora clusters #40

Closed joshbeard closed 3 years ago

joshbeard commented 3 years ago

This adds support for RDS Auora and introduces a new key in in the inventory results called 'rds-clusters'. The inventory is enabled when 'rds' is selected.

@janiko71 - not sure what your preference on how the results for RDS Aurora clusters is returned. In this initial proposal, they are in a separate "rds-clusters" key in the inventory. Please let me know if you want any tweaks. Thanks for the tool!

janiko71 commented 3 years ago

Hi, thank you for contributing! I'm happy to see that my work can be useful for some people. But unfortunately you made commits on the wrong branch... I'm working on a 'dev' branch to add services. I've merged dev and main now, and I will add comments to help developpers in the readme file.

janiko71 commented 3 years ago

Hi, I can't approve this PR as it is, because some code is missing to keep all prerequisites. Nevertheless, I've added the RDS clusters in the inventory. Thank you for help.

joshbeard commented 3 years ago

@janiko71 Hey there - thanks for adding the support! My apologies for being idle on this.