janinko / ghprb

github pull requests builder plugin for Jenkins
https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin
MIT License
370 stars 20 forks source link

Username and Secret key in Global Config automatically completed by navigator #462

Open hrodde-gpfw opened 7 years ago

hrodde-gpfw commented 7 years ago

Hi,

First thanks for the work done on this plugin!

While using this plugin I noticed that if you have logins stored in your navigator for your Jenkins account and auto-fill form enabled, then the username and the password are automatically filled by the navigator when opening the Jenkins' Configure Panel. If one does not pay attention and save another changed parameter, then GHPRB Jenkins URL override and Shared secret parameters are broken.

When used in production, this can be very tricky and can break the system every time one update the global configuration.

Here is a screenshot of the aforementioned fields: image