janinko / ghprb

github pull requests builder plugin for Jenkins
https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin
MIT License
370 stars 20 forks source link

Git URL's are case sensitive only for triggering #492

Open Claytonious opened 5 years ago

Claytonious commented 5 years ago

This causes users to think the plugin is broken because the failure mode is that builds simply don't trigger, even though the log shows no errors.

If you have, for example, a Github repository at https://github.com/test/The-Test but you configure ghprb with the url https://github.com/test/the-test, then everything will seem to work except that builds won't be triggered.

The log will say "Use webHooks is set, so not running trigger" and not build will start.

By correcting the git URL in the ghprb config for Jenkins to match the case of the Github project, triggering is fixed.

The plugin should either validate that the casing of the URL matches or it should do a case insensitive check when triggering jobs.

Leaving this here mainly to help folks who are wondering why their ghprb jobs aren't being triggered even though everything seems to be setup correctly.