search

janisdd / vscode-edit-csv

vs code extension to edit csv files with an excel like table ui
MIT License
226 stars 35 forks source link

add support for different encoding #135

Closed chaeynz closed 1 year ago

chaeynz commented 1 year ago

Version?

Id: janisdd.vscode-edit-csv Version: 0.8.3

Feature

Describe the feature you want to suggest.

Hi there! I love your extension.

Any chance you can add support for different encodings? I can't display german "Umlaut" characters. It's not absolutely necessary, but it confuses my stakeholders.

image

The encoding that I specifically work with is Windows CP 1252 (Windows-1252)

janisdd commented 1 year ago

Well, the encoding is handled by vs code. This means everything should work out of the box.

csv_windows_enc

I tested it by creating a new file and clicked on the red rectangle and changed from utf8 to windows 1252 (save with encoding). As you can see, it works ;)

It does not work, if the file is windows 1252 encoded and vs code opens it with utf8 encoding (see red rectangle). If so, click on the rectangle and choose "reopen with encoding". The same can happen if the real encoding is utf8 and the editor opens it with windows 1252 encoding.

chaeynz commented 1 year ago

You are absolutely correct! haha Sorry, my mistake! 😆

Thank you very much for the fast reply :)