search

janisdd / vscode-edit-csv

vs code extension to edit csv files with an excel like table ui
MIT License
226 stars 35 forks source link

extension not honoring my settings for "autoSave" #137

Open Morriz opened 10 months ago

Morriz commented 10 months ago

What OS?

Description

Changes are not saved according to my "files.autoSave": "onFocusChange" settings

Expected behavior

Save to happen

janisdd commented 10 months ago

None of the vs code settings affect the extension. This is intentional. Only the extension's own settings are taken into account.

I’m also not sure if this is even possible with an extension.

Morriz commented 10 months ago

aha, can it get a similar setting then? I don't understand why people still use the broken microsoft "save" paradigm when we can just undo something. It is sooooo against UX design principles...

janisdd commented 10 months ago

Well, I don’t know why having a „save“ button should be considered bad.

Saving a large file, say 100k lines, might take 2-3 seconds, which would mean a bad experience with "onFocusChange". Only after that amount of time would the actual contents of the file suddenly change.

However, I might look at this.

Morriz commented 10 months ago

I understand. I am never working with such large files myself, so never ran into such issues.