Caution : Repository is Singleton

janishar / android-mvvm-architecture

This repository contains a detailed sample app that implements MVVM architecture using Dagger2, Room, RxJava2, FastAndroidNetworking and PlaceholderView

https://janisharali.com

Apache License 2.0

2.95k stars 936 forks source link

Caution : Repository is Singleton #67

Open ashish-andev opened 4 years ago

ashish-andev commented 4 years ago

AppDataManager is a singleton. Is it recommended to keep your Repository class as Singleton?

amitshekhariitbhu commented 4 years ago

@ashish-andev It depends on the use-case like:

How frequently we are going to use that object?
How much resource is needed to create the object of that class?
What is the scope/lifetime of that object?