Counterfeit and Spoils - Githubissues

janisozaur / androminion

Automatically exported from code.google.com/p/androminion

1 stars 0 forks source link

Counterfeit and Spoils #421

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Play counterfeit
2. Select spoils

What is the expected output? What do you see instead?
Expected spoils to return to the spoils pile then nothing gets trashed due to 
the "lost track" rule. Instead spoils ends up in the trash.

Original issue reported on code.google.com by tim95...@gmail.com on 3 Sep 2012 at 2:04

GoogleCodeExporter commented 9 years ago

Original comment by buralien on 8 Sep 2012 at 9:40

Changed state: Accepted
Added labels: Component-App

GoogleCodeExporter commented 9 years ago

This issue was closed by revision r655.

Original comment by buralien on 8 Sep 2012 at 9:49

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Fixed in r655

Original comment by buralien on 8 Sep 2012 at 9:50

GoogleCodeExporter commented 9 years ago

As of DA apk from 9/13/12:

When counterfeit is played on spoils, two copies get returned to the supply, 
and one shows up in the trash.

Original comment by mooht...@gmail.com on 14 Sep 2012 at 2:57

Changed state: New
Added labels: Component-Core
Removed labels: Component-App

GoogleCodeExporter commented 9 years ago

This issue was closed by revision r664.

Original comment by buralien on 14 Sep 2012 at 1:05

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Acording to the rules for Dark Ages, "[Spoils] ... can end up in the trash if 
something trashes them."
So I think that the correct behavior after playing the above is that the player 
gains +6 coins and a single copy of Spils ends up in the trash bin. This is 
what I implemented.
Feel free to let me know if you think it should be differently.

Original comment by buralien on 14 Sep 2012 at 1:06

GoogleCodeExporter commented 9 years ago

Obviously I am wrong and the correct behaviour should be to return a single 
piece of Spoils to the Spoils pile, geting +6 coins and trashing nothing. Off 
to fix it.

Original comment by buralien on 14 Sep 2012 at 1:10

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

This issue was closed by revision r665.

Original comment by buralien on 14 Sep 2012 at 1:39

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

The reason in this particular case is that spoils is played and then played 
again and trashed. According to the rules of counterfeit it should be put in 
the spoils pile. As far as normally speaking if you trash spoils it should be 
put into the trash.

Original comment by tim95...@gmail.com on 14 Sep 2012 at 4:05