janisozaur / androminion

Automatically exported from code.google.com/p/androminion
1 stars 0 forks source link

Doctor places cards back on the deck in reverse order #595

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Play a Doctor such that two or more cards are put back on the deck.
2. Play a card to draw the next card (or next two, or next three).

What is the expected output? What do you see instead?
The card on the top, closest to where it says "Top of Deck" in the dialog, 
should be drawn first. Instead, it is drawn last. This is particularly noisome 
when playing a Doctor followed by a Herald, or any other card that cares what 
order the top of your deck is in.

What version of the product are you using? On what operating system?
Guilds branch latest, Android 4.2.2 on Samsung S4.

Please provide any additional information below.

Original issue reported on code.google.com by wesc...@gmail.com on 27 Oct 2013 at 6:45

GoogleCodeExporter commented 9 years ago
In doctor() there's 
            for (Card c : orderedCards) {
                currentPlayer.putOnTopOfDeck(c);
            }
instead of
            // Put the cards back on the deck
            for (int i = orderedCards.size() - 1; i >= 0; i--) {
                currentPlayer.putOnTopOfDeck(orderedCards.get(i));
            }

Original comment by frank.ro...@gmail.com on 28 Dec 2014 at 4:17

GoogleCodeExporter commented 9 years ago
Fixed in r916 (multiplayer).

Original comment by andromin...@gmail.com on 15 Mar 2015 at 11:00