janisozaur / include-what-you-use

Automatically exported from code.google.com/p/include-what-you-use
Other
0 stars 0 forks source link

Windows-unfriendly glob pattern in iwyu_stricter_than_cpp check_also spec #103

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The glob pattern specified in run_iwyu_tests.py is not valid on Windows. The 
function we're using on Windows does not accept character classes in glob 
patterns, so the [^0-9] suffix won't match anything.

The attached patch lists all check-also files explicitly, and we need to 
remember to maintain the list if we add another include that needs also be 
checked.

With this change, the test passes here.

Original issue reported on code.google.com by kim.gras...@gmail.com on 19 Jul 2013 at 8:34

Attachments:

GoogleCodeExporter commented 9 years ago
It's a pity that [^0-9] expression isn't supported, but I think it's OK to list 
3 cases explicitly.

Original comment by vsap...@gmail.com on 24 Jul 2013 at 10:46

GoogleCodeExporter commented 9 years ago
Thanks, r481.

Original comment by kim.gras...@gmail.com on 25 Jul 2013 at 6:38