search

janithcooray / lin_os_swap_mod

increases the SWAP memory by an additional 4GB or 8GB for Android 7.0 or above
GNU General Public License v3.0
78 stars 6 forks source link

Fix reversed logic for "Set Swap Priority above Zram?" option. #16

Closed Animesh-Does-Code closed 8 months ago

Animesh-Does-Code commented 9 months ago

This was caused by commit https://github.com/janithcooray/lin_os_swap_mod/commit/84440c9f969341a65478003c07911a714c8169df and is related to issue https://github.com/janithcooray/lin_os_swap_mod/issues/10. OVER_ZRAM_PRIOR's values in customize.sh were reversed from what they should be, so answering 'Yes' would not set the swapfile's priority to 0 as expected.

PowerUser64 commented 8 months ago

This is pretty important for users to know, can we get this merged into main asap so people aren't mislead?

Animesh-Does-Code commented 8 months ago

This is pretty important for users to know, can we get this merged into main asap so people aren't mislead?

I'm a little new to creating pull requests, but I've actually used the 12-typo-error-crating-is-still-not-fixed-in-customizesh branch to add my commit which contains some typo fixes as well which are pending in pull request #13.

Not sure if that was the best idea, or if I should create a new pull request and add my commit to a clone of the main branch instead, which does not contain any other pending changes.

I'm okay with whatever works best according to the repo's owner, as long as it can get merged somehow.

PowerUser64 commented 8 months ago

I'm a little new to creating pull requests

:+1:

For pull requests, it is generally considered best practice to isolate things to their own PR/branch, so all the things related to a change are in the same place. One new branch for each PR, and commits from one PR shouldn't be in any others. I would recommend you read through free code camp's guide to making a PR, because it offers some good tips: https://www.freecodecamp.org/news/how-to-make-your-first-pull-request-on-github-3/

If you wanted to, you could try making a new clean branch, redoing your modifications there, then force pushing them here, but make sure to create a copy of your code first if you don't have much experience with git. It's going to cause merge conflicts if both branches are merged if changes from one were also made in the other.