jank-lang / jank

The native Clojure dialect hosted on LLVM
https://jank-lang.org
Mozilla Public License 2.0
1.7k stars 50 forks source link

Add support for all remaining simple escape sequences #102

Closed jianlingzhong closed 1 month ago

jianlingzhong commented 1 month ago

This closes #97.

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

jeaye commented 1 month ago

So, there's some missing work here. Check out the steps in the ticket for details: https://github.com/jank-lang/jank/issues/97

We've done the first and third, as part of this PR, but the second and fourth are needed in order for this to fully work. Right now, we will lex these escape sequences, but they won't be parsed properly. To see what I mean, try this:

$ jank repl
> "\v"
jianlingzhong commented 1 month ago

@jeaye updated. could you take another look?

jeaye commented 1 month ago

Looks great!