This looks great. I think we need a more rigorous testing suite for it, though. There are paths in the code which aren't currently being tested, like 1ee1, 1Efoo, etc. As I mentioned in the ticket, the main work for this task is going to be the negative test suite. Let's try to permutate all of the ways this could go wrong.
This looks great. I think we need a more rigorous testing suite for it, though. There are paths in the code which aren't currently being tested, like
1ee1,1Efoo, etc. As I mentioned in the ticket, the main work for this task is going to be the negative test suite. Let's try to permutate all of the ways this could go wrong.