search

jank-lang / jank

The native Clojure dialect hosted on LLVM
https://jank-lang.org
Mozilla Public License 2.0
1.69k stars 50 forks source link

Build dependencies misses `git-lfs` #83

Closed tealeg closed 3 months ago

tealeg commented 3 months ago

I was following the build instructions, on a Mac OS X machine, and noticed that cloning the repository without git-lfs installed fails:

> git clone --recurse-submodules https://github.com/jank-lang/jank.git
Cloning into 'jank'...
remote: Enumerating objects: 32717, done.
remote: Counting objects: 100% (764/764), done.
remote: Compressing objects: 100% (329/329), done.
remote: Total 32717 (delta 488), reused 559 (delta 396), pack-reused 31953
Receiving objects: 100% (32717/32717), 4.35 MiB | 3.24 MiB/s, done.
Resolving deltas: 100% (17149/17149), done.
git-lfs filter-process: git-lfs: command not found
fatal: the remote end hung up unexpectedly
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

I would propose adding that dependency into the brew install line of the docs.

jeaye commented 3 months ago

Seems sensible to me! Thanks for the report.